linux-kernel - Re: [PATCH] Squashfs: Fix oops when reading fsfuzzer corrupted filesystems

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-Id: <20090205122215.adcd18db.akpm@linux-foundation.org>
Date:	Thu, 5 Feb 2009 12:22:15 -0800
From:	Andrew Morton <akpm@...ux-foundation.org>
To:	Phillip Lougher <phillip@...gher.demon.co.uk>
Cc:	linux-fsdevel@...r.kernel.org, linux-kernel@...r.kernel.org,
	snakebyte@....de, sliedes@...hut.fi, phillip@...gher.demon.co.uk
Subject: Re: [PATCH] Squashfs: Fix oops when reading fsfuzzer corrupted
 filesystems

On Wed, 04 Feb 2009 03:07:48 +0000
Phillip Lougher <phillip@...gher.demon.co.uk> wrote:

> -	ERROR("sb_bread failed reading block 0x%llx\n", cur_index);
> +	ERROR("squashfs_read_data failed to read block 0x%llx\n", index);

`index' has type u64.  You don't know what C type is used to implement
u64, hence it must be cast to a known type before it can be passed to
printk.

In this case we use `unsigned long long'.

The code as it stands will generate compiler warnings on some
architectures.

One day, maybe before we all die, we will fix this.  Then we get to
spend another five years weeding out all the casts we added.

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/