linux-kernel - Re: PATCH: Allow over-ride of smp_found

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <498B4FD1.9000804@candelatech.com>
Date:	Thu, 05 Feb 2009 12:45:05 -0800
From:	Ben Greear <greearb@...delatech.com>
To:	Ingo Molnar <mingo@...e.hu>
CC:	Yinghai Lu <yinghai@...nel.org>, "H. Peter Anvin" <hpa@...or.com>,
	Thomas Gleixner <tglx@...utronix.de>,
	"Maciej W. Rozycki" <macro@...ux-mips.org>,
	linux-kernel <linux-kernel@...r.kernel.org>, len.brown@...el.com
Subject: Re: PATCH:  Allow over-ride of smp_found_cfg with kernel cmd-line
 option.

Ingo Molnar wrote:

> I'd _much_ rather have a warning message printed and have a default, 
> unconditional fallback to mptable parsing in this case.
> 
> I.e. same end result just no ugly and inconvenient force_smp_found_cfg.
> 
> The mptable works fine in most such cases to enumerate apic details. (as it 
> does in your case, evidently)
> 
> And if both the ACPI and the MPTABLE is hosed on a box, it cannot be of much 
> use on other OSs either, right?
> 
> So please do a patch that removes the 'smp_found_config' and which changes 
> the warning message to warn about no ACPI table in the MADT table. Ok?

That is fine with me, but I know next to zero about the deep logic
of this code.  I'd be worried that Len put in the change to fix something
more critical than my problem on my particular board.

If no one argues otherwise, I'll get a patch together & tested this evening.

Thanks,
Ben

-- 
Ben Greear <greearb@...delatech.com>
Candela Technologies Inc  http://www.candelatech.com

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/