linux-kernel - Re: [PATCH 5/5] Blackfin SPI Driver: Make mmc

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-Id: <20090205141302.be8b3217.akpm@linux-foundation.org>
Date:	Thu, 5 Feb 2009 14:13:02 -0800
From:	Andrew Morton <akpm@...ux-foundation.org>
To:	Bryan Wu <cooloney@...nel.org>
Cc:	dbrownell@...rs.sourceforge.net,
	spi-devel-general@...ts.sourceforge.net,
	linux-kernel@...r.kernel.org, wolfgang.mues@...rswald.de,
	yi.li@...log.com, cooloney@...nel.org
Subject: Re: [PATCH 5/5] Blackfin SPI Driver: Make mmc_spi driver work on
 Blackfin

On Thu,  5 Feb 2009 18:07:33 +0800
Bryan Wu <cooloney@...nel.org> wrote:

> 1. Rewrite of the non-dma data transfer functions to use only ONE
> mode of TIMOD (TIMOD=0x1). With TIMOD=0, it was not possible to set
> the TX bit pattern. So the TDBR = 0xFFFF inside the read calls won't
> work.
> 
> 2. Clear SPI_RDBR before reading and before duplex transfer. Otherwise
> the garbage data in RDBR will get read. Since mmc_spi uses a lot of
> duplex transfers, this is the main cause of mmc_spi failure.
> 
> 3. Poll RXS for transfer completion. Polling SPIF or TXS cannot
> guarantee transfer completion. This may interrupt a transfer before
> it is finished. Also this may leave garbage data in buffer and
> affect next transfer.
> 
> [Yi Li <yi.li@...log.com>: add a field "u16 idle_tx_val" in "struct
> bfin5xx_spi_chip" to specify the value to transmit if no TX value
> is supplied.]


again, driver-core has destroyed your patch.

There was no _need_ to take the unusual and undesirable step of
modifying SPI via an unrelated tree.
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/