linux-kernel - Re: [PATCH 2/5] percpu: Refactor percpu.h

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <12c511ca0902051430w78ca10d9rf96804748ce6ea79@mail.gmail.com>
Date:	Thu, 5 Feb 2009 14:30:45 -0800
From:	Tony Luck <tony.luck@...el.com>
To:	Brian Gerst <brgerst@...il.com>
Cc:	Tejun Heo <tj@...nel.org>, Ingo Molnar <mingo@...e.hu>,
	linux-kernel@...r.kernel.org
Subject: Re: [PATCH 2/5] percpu: Refactor percpu.h

On Sun, Jan 18, 2009 at 4:52 PM, Brian Gerst <brgerst@...il.com> wrote:
> Refactor the DEFINE_PER_CPU_* macros and add .data.percpu.first
> section.
>
> Signed-off-by: Brian Gerst <brgerst@...il.com>

> diff --git a/include/linux/percpu.h b/include/linux/percpu.h
> index 9f2a375..0e24202 100644
> --- a/include/linux/percpu.h
> +++ b/include/linux/percpu.h
...

> +#define DEFINE_PER_CPU_SECTION(type, name, section)                    \
> +       __attribute__((__section__(PER_CPU_BASE_SECTION section)))      \
>        PER_CPU_ATTRIBUTES __typeof__(type) per_cpu__##name

Brian,

This causes errors for CONFIG_SMP=n builds on ia64.  If you look
at arch/ia64/include/asm/percpu.h you'll see that the !SMP case has


#define PER_CPU_ATTRIBUTES      __attribute__((__section__(".data.percpu")))

So we end up with section attributes of both ".data" and
".data.percpu" for every
DEFINE_PER_CPU used.  The compiler doesn't like that at all :-(


Perhaps PER_CPU_BASE_SECTION needs to be defined by <asm/percpu.h>
so ia64 can avoid the section conflict?

-Tony
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/