linux-kernel - Re: [PATCH 6/6] x86: unify fixmap.h

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20090205234529.GC14203@elte.hu>
Date:	Fri, 6 Feb 2009 00:45:29 +0100
From:	Ingo Molnar <mingo@...e.hu>
To:	"Gustavo F. Padovan" <gustavo@....ic.unicamp.br>
Cc:	linux-kernel@...r.kernel.org, glommer@...hat.com,
	"H. Peter Anvin" <hpa@...or.com>,
	Thomas Gleixner <tglx@...utronix.de>
Subject: Re: [PATCH 6/6] x86: unify fixmap.h


* Gustavo F. Padovan <gustavo@....ic.unicamp.br> wrote:

> This patch unify fixmap_32.h and fixmap_64.h into fixmap.h.
> Things that we can't merge now are using CONFIG_X86_{32,64}
> (e.g.:vsyscall and EFI)
> 
> Signed-off-by: Gustavo F. Padovan <gustavo@....ic.unicamp.br>
> Acked-by: Glauber Costa <gcosta@...hat.com>
> ---
>  arch/x86/include/asm/fixmap.h    |  153 +++++++++++++++++++++++++++++++++++++-
>  arch/x86/include/asm/fixmap_32.h |  119 -----------------------------
>  arch/x86/include/asm/fixmap_64.h |   94 -----------------------
>  3 files changed, 151 insertions(+), 215 deletions(-)
>  delete mode 100644 arch/x86/include/asm/fixmap_32.h
>  delete mode 100644 arch/x86/include/asm/fixmap_64.h

Please split this patch up into 3 parts:

 #1: "x86: prepare fixmap_32.h for unification"
 #2: "x86: prepare fixmap_64.h for unification"
 #3: "x86: mechanic unification of fixmap_32/64.h => fixmap.h"

ok?

That way it's reviewable what happened during the unification,
with the above patch it isnt.

	Ingo
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/