[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Message-Id: <1233902125.2604.328.camel@ymzhang>
Date: Fri, 06 Feb 2009 14:35:25 +0800
From: "Zhang, Yanmin" <yanmin_zhang@...ux.intel.com>
To: Paul Mackerras <paulus@...ba.org>
Cc: Ingo Molnar <mingo@...e.hu>, linux-kernel@...r.kernel.org
Subject: Re: [PATCH] perf_counter: Prevent oopses from per-cpu software
counters
On Fri, 2009-02-06 at 15:34 +1100, Paul Mackerras wrote:
> Ingo Molnar writes:
>
> > So how about fixing these sw counts to properly work as percpu counters too?
>
> OK, so for page faults it looks like I want to look at
>
> get_cpu_var(vm_event_states).event[PGFAULT]
>
> to get the per-cpu page fault count, as long as
> CONFIG_VM_EVENT_COUNTERS is set.
>
> It looks like the scheduler doesn't keep per-cpu counts of context
> switches
rq->sched_switch or sched_count? sched_switch is defined, but not used. They
all depends on CONFIG_SCHEDSTATS=y.
> or task migrations, or if it does I couldn't find them. We
> could do stuff in perf_counter_task_sched_in/out to implement per-cpu
> context switch and migration counters by adding up the delta values
> for each task that gets scheduled onto the cpu. Or we could add
> explicit per-cpu counters for these things in the scheduler.
>
> What do you think?
>
> Paul.
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/
Powered by blists - more mailing lists