linux-kernel - RE: [PATCH] Input: bf54x-keys: ! has a higher priority than >

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <8A42379416420646B9BFAC9682273B6D0883413D@limkexm3.ad.analog.com>
Date:	Fri, 6 Feb 2009 08:49:49 -0000
From:	"Hennerich, Michael" <Michael.Hennerich@...log.com>
To:	"Andrew Morton" <akpm@...ux-foundation.org>,
	"Bryan Wu" <cooloney@...nel.org>
Cc:	<dmitry.torokhov@...il.com>, <linux-input@...r.kernel.org>,
	<linux-kernel@...r.kernel.org>, <roel.kluin@...il.com>,
	<michael.hennerich@...log.com>, <cooloney@...nel.org>
Subject: RE: [PATCH] Input: bf54x-keys: ! has a higher priority than >



>From: Andrew Morton [mailto:akpm@...ux-foundation.org]
>Sent: Thursday, February 05, 2009 11:01 PM
>Subject: Re: [PATCH] Input: bf54x-keys: ! has a higher priority than >
>
>On Thu,  5 Feb 2009 15:19:55 +0800
>Bryan Wu <cooloney@...nel.org> wrote:
>
>> From: Roel Kluin <roel.kluin@...il.com>
>>
>> Signed-off-by: Roel Kluin <roel.kluin@...il.com>
>> Signed-off-by: Michael Hennerich <michael.hennerich@...log.com>
>> Signed-off-by: Bryan Wu <cooloney@...nel.org>
>> ---
>>  drivers/input/keyboard/bf54x-keys.c |    4 ++--
>>  1 files changed, 2 insertions(+), 2 deletions(-)
>>
>> diff --git a/drivers/input/keyboard/bf54x-keys.c
>b/drivers/input/keyboard/bf54x-keys.c
>> index 1928401..ee855c5 100644
>> --- a/drivers/input/keyboard/bf54x-keys.c
>> +++ b/drivers/input/keyboard/bf54x-keys.c
>> @@ -209,8 +209,8 @@ static int __devinit bfin_kpad_probe(struct
>platform_device *pdev)
>>  		goto out;
>>  	}
>>
>> -	if (!pdata->debounce_time || !pdata->debounce_time > MAX_MULT ||
>> -	    !pdata->coldrive_time || !pdata->coldrive_time > MAX_MULT) {
>> +	if (!pdata->debounce_time || pdata->debounce_time > MAX_MULT ||
>> +	    !pdata->coldrive_time || pdata->coldrive_time > MAX_MULT) {
>
>What is this `pdata' thing from which the data comes?

Platform device data.

struct bfin_kpad_platform_data *pdata = pdev->dev.platform_data;

>
>It seems a bit rude to kill the driver when we've detected an error
>which could easily be fixed up.

It actually just prints the error and then uses some default value later
on.

>
>>  		printk(KERN_ERR DRV_NAME
>>  			": Invalid Debounce/Columdrive Time from
pdata\n");
>
>nit: a colon does not terminate a sentence.
>
>This comment misspells "column".

Bryan will send a patch addressing this typo.

Best regards,
Michael
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/