linux-kernel - Re: [PATCHv2] PCI: add missing KERN

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <498BFC67.6030701@jp.fujitsu.com>
Date:	Fri, 06 Feb 2009 18:01:27 +0900
From:	Taku Izumi <izumi.taku@...fujitsu.com>
To:	Frank Seidel <fseidel@...e.de>
CC:	linux kernel <linux-kernel@...r.kernel.org>,
	linux-pci@...r.kernel.org, jbarnes@...tuousgeek.org,
	greg@...ah.com, kristen.c.accardi@...el.com, ashok.raj@...el.com,
	shaohua.li@...el.com, anil.s.keshavamurthy@...el.com,
	fenghua.yu@...el.com, akpm@...ux-foundation.org, frank@...eidel.de,
	Frans Pop <elendil@...net.nl>,
	Geert Uytterhoeven <Geert.Uytterhoeven@...ycom.com>
Subject: Re: [PATCHv2] PCI: add missing KERN_* constants to printks



Frank Seidel wrote:
> From: Frank Seidel <frank@...eidel.de>
> 
> According to kerneljanitors todo list all printk calls (beginning
> a new line) should have an according KERN_* constant.
> Those are the missing pieces here for the pci subsystem.
> 
> Signed-off-by: Frank Seidel <frank@...eidel.de>
> ---
>  drivers/pci/hotplug/pciehp.h |    3 ++-
>  drivers/pci/hotplug/shpchp.h |    3 ++-
>  drivers/pci/intel-iommu.c    |    2 +-
>  3 files changed, 5 insertions(+), 3 deletions(-)
> 
> --- a/drivers/pci/intel-iommu.c
> +++ b/drivers/pci/intel-iommu.c
> @@ -1960,7 +1960,7 @@ static inline void iommu_prepare_isa(voi
>  	ret = iommu_prepare_identity_map(pdev, 0, 16*1024*1024);
>  
>  	if (ret)
> -		printk("IOMMU: Failed to create 0-64M identity map, "
> +		printk(KERN_ERR "IOMMU: Failed to create 0-64M identity map, "
>  			"floppy might not work\n");
>  
>  }
> --- a/drivers/pci/hotplug/pciehp.h
> +++ b/drivers/pci/hotplug/pciehp.h
> @@ -48,7 +48,8 @@ extern struct workqueue_struct *pciehp_w
>  #define dbg(format, arg...)						\
>  	do {								\
>  		if (pciehp_debug)					\
> -			printk("%s: " format, MY_NAME , ## arg);	\
> +			printk(KERN_DEBUG "%s: " format, MY_NAME ,	\
> +			       ## arg);					\
>  	} while (0)
>  #define err(format, arg...)						\
>  	printk(KERN_ERR "%s: " format, MY_NAME , ## arg)

  Why didn't you retouch the following dev_printk ?

#define ctrl_dbg(ctrl, format, arg...)                                  \
        do {                                                            \
                if (pciehp_debug)                                       \
                        dev_printk(, &ctrl->pcie->device,               \
                                        format, ## arg);                \
        } while (0)

> --- a/drivers/pci/hotplug/shpchp.h
> +++ b/drivers/pci/hotplug/shpchp.h
> @@ -50,7 +50,8 @@ extern struct workqueue_struct *shpchp_w
>  #define dbg(format, arg...)						\
>  	do {								\
>  		if (shpchp_debug)					\
> -			printk("%s: " format, MY_NAME , ## arg);	\
> +			printk(KERN_DEBUG "%s: " format, MY_NAME ,	\
> +			       ## arg);					\
>  	} while (0)
>  #define err(format, arg...)						\
>  	printk(KERN_ERR "%s: " format, MY_NAME , ## arg)
> 
> 
> --
> To unsubscribe from this list: send the line "unsubscribe linux-pci" in
> the body of a message to majordomo@...r.kernel.org
> More majordomo info at  http://vger.kernel.org/majordomo-info.html
> 
> 

-- 
Best regards,
Taku Izumi

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/