linux-kernel - Re: [PATCH 001/001] usbserial: New mobile broadband modems to be supported through option module

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-Id: <200902061258.40303.oliver@neukum.org>
Date:	Fri, 6 Feb 2009 12:58:39 +0100
From:	Oliver Neukum <oliver@...kum.org>
To:	"Dirk DeSchepper" <ddeschepper@...l.com>,
	USB development list <linux-usb@...r.kernel.org>
Cc:	"Greg KH" <greg@...ah.com>, smurf@...rf.noris.de,
	linux-kernel@...r.kernel.org
Subject: Re: [PATCH 001/001]  usbserial: New mobile broadband modems to be supported through option module

Am Friday 06 February 2009 12:29:06 schrieb Dirk DeSchepper:
> From: Dirk De Schepper <ddeschepper@...l.com>
> 
> Patch for option.c, based on kernel v2.6.28.3
> - New Novatel and Dell mobile broadband modem products added
> - Dell pid variables used in stead of numerical PIDs for known products

This is not really an advantage. You usually get the nummeric IDs
just fine from lsusb. And you could easily see the nummeric order of entries.
These symbolic names do not appear in code, just in the macros
where their meaning is clear. You introduce a useless level of indirection.

	Regards
		Oliver
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/