linux-kernel - Re: [PATCH] mfd/htc-egpio: fix iomem resource handling using resource

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20090206140310.GG3341@sortiz.org>
Date:	Fri, 6 Feb 2009 15:03:11 +0100
From:	Samuel Ortiz <sameo@...nedhand.com>
To:	Philipp Zabel <philipp.zabel@...il.com>
Cc:	linux-kernel@...r.kernel.org
Subject: Re: [PATCH] mfd/htc-egpio: fix iomem resource handling using
	resource_size

On Sat, Jan 31, 2009 at 09:47:43PM +0100, Philipp Zabel wrote:
> Fixes an off-by-one error in the iomem resource mapping.
Applied to my for-linus branch. Will Send a pull request to Linus soon.
Thanks a lot.

Cheers,
Samuel.

 
> Signed-off-by: Philipp Zabel <philipp.zabel@...il.com>
> ---
>  drivers/mfd/htc-egpio.c |    2 +-
>  1 files changed, 1 insertions(+), 1 deletions(-)
> 
> diff --git a/drivers/mfd/htc-egpio.c b/drivers/mfd/htc-egpio.c
> index 1a4d046..e9b0745 100644
> --- a/drivers/mfd/htc-egpio.c
> +++ b/drivers/mfd/htc-egpio.c
> @@ -286,7 +286,7 @@ static int __init egpio_probe(struct platform_device *pdev)
>  	res = platform_get_resource(pdev, IORESOURCE_MEM, 0);
>  	if (!res)
>  		goto fail;
> -	ei->base_addr = ioremap_nocache(res->start, res->end - res->start);
> +	ei->base_addr = ioremap_nocache(res->start, resource_size(res));
>  	if (!ei->base_addr)
>  		goto fail;
>  	pr_debug("EGPIO phys=%08x virt=%p\n", (u32)res->start, ei->base_addr);
> -- 
> 1.5.6.5
> 

-- 
Intel Open Source Technology Centre
http://oss.intel.com/
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/