linux-kernel - Re: [PATCH] crypto: add missing KERN

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <498C4F2E.1070204@f-seidel.de>
Date:	Fri, 06 Feb 2009 15:54:38 +0100
From:	Frank Seidel <frank@...eidel.de>
To:	Alexey Dobriyan <adobriyan@...il.com>
CC:	Frank Seidel <fseidel@...e.de>,
	linux kernel <linux-kernel@...r.kernel.org>,
	akpm@...ux-foundation.org, "David S. Miller" <davem@...emloft.net>,
	linux-crypto@...r.kernel.org, herbert@...dor.apana.org.au,
	jarod@...hat.com
Subject: Re: [PATCH] crypto: add missing KERN_* constants to printks

Alexey Dobriyan schrieb:
> On Fri, Feb 06, 2009 at 03:19:10PM +0100, Frank Seidel wrote:
>> According to kerneljanitors todo list all printk calls (beginning
>> a new line) should have an according KERN_* constant.
> 
> Forget about kernel janitors todo list, fix a bug instead.

Sure, i am eager to get my hands dirty in the kernel ;-),
but i needed to start somewhere and everybody told me
that the janitors todo list would be good place to start.

>> Those are the missing pieces here for the crypto subsystem.
> 
> You're inserting KERN_WARNING everywhere, what for?

Because every new line should have KERN_* constant and
KERN_WARNING is default/doesn't change current printout
behaviour.

Thanks,
Frank
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/