linux-kernel - Re: [PATCH] usb: musb: tweak musb_read

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20090206193027.GF10711@frodo>
Date:	Fri, 6 Feb 2009 21:30:27 +0200
From:	Felipe Balbi <me@...ipebalbi.com>
To:	Mike Frysinger <vapier.adi@...il.com>
Cc:	me@...ipebalbi.com, Bryan Wu <cooloney@...nel.org>,
	felipe.balbi@...ia.com, linux-usb@...r.kernel.org,
	linux-kernel@...r.kernel.org
Subject: Re: [PATCH] usb: musb: tweak musb_read_fifo() to avoid unused
	warnings

On Fri, Feb 06, 2009 at 02:28:46PM -0500, Mike Frysinger wrote:
> >> the subject already says that
> >
> > the subject says:
> >
> > "tweak musb_read_fifo() to avoid unused warnings"
> >
> > it doesn't specify where are the warnings.
> 
> i dont think it really adds anything to explicitly mention every
> variable that triggers an unused warning.  but if we look at the code
> that changed, it's easy to see that it's epnum and dma_reg.

Still I like to see patch bodies otherwise git log will look awkward.

-- 
balbi
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/