linux-kernel - Re: Regression on VIA C3 motherboard, commit: 66f2173e2

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <498C951A.3070101@candelatech.com>
Date:	Fri, 06 Feb 2009 11:52:58 -0800
From:	Ben Greear <greearb@...delatech.com>
To:	Len Brown <lenb@...nel.org>
CC:	linux-kernel <linux-kernel@...r.kernel.org>,
	NetDev <netdev@...r.kernel.org>, linux-acpi@...r.kernel.org
Subject: Re: Regression on VIA C3 motherboard, commit: 66f2173e2

Len Brown wrote:
> Thanks for the bisect, Ben.
> 
> Please test the patch below.

With this patch, performance is fine, and I do not see
my smp hack being exercised.  I still have ACPI off
in the BIOS, and on in the kernel (ie, no change
from the original test case).

So, this very well could be the fix.

Thanks,
Ben

> diff --git a/drivers/acpi/tables.c b/drivers/acpi/tables.c
> index 775c97a..a885295 100644
> --- a/drivers/acpi/tables.c
> +++ b/drivers/acpi/tables.c
> @@ -293,7 +293,12 @@ static void __init check_multiple_madt(void)
>  
>  int __init acpi_table_init(void)
>  {
> -	acpi_initialize_tables(initial_tables, ACPI_MAX_TABLES, 0);
> +	acpi_status status;
> +
> +	status = acpi_initialize_tables(initial_tables, ACPI_MAX_TABLES, 0);
> +	if (ACPI_FAILURE(status))
> +		return 1;
> +
>  	check_multiple_madt();
>  	return 0;
>  }


-- 
Ben Greear <greearb@...delatech.com>
Candela Technologies Inc  http://www.candelatech.com

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/