linux-kernel - Re: [PATCH] Soekris net5501 board support code

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Date:	Sat, 7 Feb 2009 00:35:22 +0100
From:	Alessandro Zummo <alessandro.zummo@...ertech.it>
To:	Andrew Morton <akpm@...ux-foundation.org>
Cc:	linux-kernel@...r.kernel.org, rpurdie@...ys.net, mingo@...e.hu,
	tglx@...utronix.de, hpa@...or.com
Subject: Re: [PATCH] Soekris net5501 board support code

On Fri, 6 Feb 2009 15:21:21 -0800
Andrew Morton <akpm@...ux-foundation.org> wrote:

> > +	rombase = ioremap(0xffff0000, 0xffff);
> > +	if (!rombase)
> > +		return 0;  
> 
> Is it appropriate to silently "succeed" if the ioremap() failed?

 maybe not.. I'll add a printk. ty.

-- 

 Best regards,

 Alessandro Zummo,
  Tower Technologies - Torino, Italy

  http://www.towertech.it

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/