[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Message-ID: <20090207232458.GB23407@bombadil.infradead.org>
Date: Sat, 7 Feb 2009 18:24:58 -0500
From: Kyle McMartin <kyle@...radead.org>
To: Chuck Ebbert <cebbert@...hat.com>
Cc: linux-kernel@...r.kernel.org, Chris Mason <chris.mason@...cle.com>,
Ingo Molnar <mingo@...e.hu>
Subject: Re: Build failure with latest -git: btrfs on ppc64
On Sat, Feb 07, 2009 at 03:50:39PM -0500, Chuck Ebbert wrote:
> fs/btrfs/locking.c: In function 'btrfs_path_lock_waiting':
> fs/btrfs/locking.c:254: error: implicit declaration of function '__raw_spin_is_contended'
>
> Looks like spin_is_contended() is only available on mips and x86??
>
Looks to be if there are other folks in line for the ticket lock.
Arguably this should probably be something silly in spinlock.h like,
#ifndef __raw_spin_is_contended
# define spin_is_contended (0)
#else
# define spin_is_contended(x) __raw_spin_is_contended((x))
#endif
or something since in theory anybody has a chance of acquiring it next
(well, lies because caches bias, but there's no waiters at least.)
Either that, or we just define it to be spin_is_locked if the assumption
is that the lock will continue to be locked...
regards, Kyle
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/
Powered by blists - more mailing lists