linux-kernel - Re: [PATCH] usb: musb: tweak musb_read

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <8bd0f97a0902062029l7cfd58d2ga0c12f2c33cc9d93@mail.gmail.com>
Date:	Fri, 6 Feb 2009 23:29:54 -0500
From:	Mike Frysinger <vapier.adi@...il.com>
To:	Greg KH <greg@...ah.com>
Cc:	Bryan Wu <cooloney@...nel.org>, felipe.balbi@...ia.com,
	linux-usb@...r.kernel.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH] usb: musb: tweak musb_read_fifo() to avoid unused 
	warnings

On Fri, Feb 6, 2009 at 19:01, Greg KH wrote:
> On Fri, Feb 06, 2009 at 06:22:16PM +0800, Bryan Wu wrote:
>> From: Mike Frysinger <vapier.adi@...il.com>
>>
>> Signed-off-by: Mike Frysinger <vapier.adi@...il.com>
>> Signed-off-by: Bryan Wu <cooloney@...nel.org>
>> ---
>>  drivers/usb/musb/blackfin.c |    9 +++++----
>>  1 files changed, 5 insertions(+), 4 deletions(-)
>>
>> diff --git a/drivers/usb/musb/blackfin.c b/drivers/usb/musb/blackfin.c
>> index 7861348..0ebb19d 100644
>> --- a/drivers/usb/musb/blackfin.c
>> +++ b/drivers/usb/musb/blackfin.c
>> @@ -54,13 +54,11 @@ void musb_write_fifo(struct musb_hw_ep *hw_ep, u16 len, const u8 *src)
>>  void musb_read_fifo(struct musb_hw_ep *hw_ep, u16 len, u8 *dst)
>>  {
>>       void __iomem *fifo = hw_ep->fifo;
>> +
>> +#ifdef CONFIG_BF52x
>
> Any way we can just not have ifdefs in .c files alltogether?

the sub arch.c files for musb are pretty much header files.  the
alternative (splitting up the funcs into their own header files) would
be much more bothersome for us to maintain atm i think since there's
so very little different.
-mike
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/