linux-kernel - Re: Gem GTT mmaps..

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-Id: <1233993994.5537.5.camel@badjo>
Date:	Sat, 07 Feb 2009 09:06:34 +0100
From:	Xavier Bestel <xavier.bestel@...e.fr>
To:	Jesse Barnes <jbarnes@...tuousgeek.org>
Cc:	Thomas Hellström <thomas@...pmail.org>,
	Eric Anholt <eric@...olt.net>,
	DRI <dri-devel@...ts.sourceforge.net>,
	Linux Kernel <linux-kernel@...r.kernel.org>
Subject: Re: Gem GTT mmaps..

Le vendredi 06 février 2009 à 14:24 -0800, Jesse Barnes a écrit :
> +       map = list->map;
> +       if (map) {
> +               drm_free(map, sizeof(*map), DRM_MEM_DRIVER);
> +               list->map = NULL;

I would have inverted the two last lines (otherwise why wouldn't you
directly drw_free(list->map) ?).

	Xav


--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/