linux-kernel - Re: [PATCH] kernel/irq: fix sparse warning: make symbol static

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:	Sun, 8 Feb 2009 16:09:10 -0700
From:	Matthew Wilcox <matthew@....cx>
To:	Hannes Eder <hannes@...neseder.net>
Cc:	Ingo Molnar <mingo@...e.hu>, kernel-janitors@...r.kernel.org,
	linux-kernel@...r.kernel.org
Subject: Re: [PATCH] kernel/irq: fix sparse warning: make symbol static

On Sun, Feb 08, 2009 at 08:24:47PM +0100, Hannes Eder wrote:
> -static inline int do_irq_select_affinity(int irq, struct irq_desc *desc)
> +static inline int do_irq_select_affinity(unsigned int irq, struct irq_desc *desc)

Does this not introduce a checkpatch warning about a line being longer
than 80 columns?  Three acceptable ways to fix this:

static inline
int do_irq_select_affinity(unsigned int irq, struct irq_desc *desc)

static inline int do_irq_select_affinity(unsigned int irq,
							struct irq_desc *desc)

static inline int do_irq_select_affinity(unsigned irq, struct irq_desc *desc)

My favourite is the last one.

-- 
Matthew Wilcox				Intel Open Source Technology Centre
"Bill, look, we understand that you're interested in selling us this
operating system, but compare it to ours.  We can't possibly take such
a retrograde step."
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/