linux-kernel - Re: [urcu PATCH] test

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20090208001713.GA5282@Krystal>
Date:	Sat, 7 Feb 2009 19:17:13 -0500
From:	Mathieu Desnoyers <compudj@...stal.dyndns.org>
To:	Bert Wesarg <bert.wesarg@...glemail.com>
Cc:	linux-kernel@...r.kernel.org
Subject: Re: [urcu PATCH] test_urcu.c: use gettid()

* Bert Wesarg (bert.wesarg@...glemail.com) wrote:
> It's probably better to print the tid for each thread, not the pid.
> 
> Signed-off-by: Bert Wesarg <bert.wesarg@...glemail.com>
> 
Merged, thanks !

Mathieu

> ---
>  test_urcu.c |   28 ++++++++++++++++++++++++----
>  1 files changed, 24 insertions(+), 4 deletions(-)
> 
> diff --git a/test_urcu.c b/test_urcu.c
> index db0b68c..ea5a784 100644
> --- a/test_urcu.c
> +++ b/test_urcu.c
> @@ -17,6 +17,23 @@
>  #include <unistd.h>
>  #include <stdio.h>
>  #include <assert.h>
> +#include <sys/syscall.h>
> +
> +#if defined(_syscall0)
> +_syscall0(pid_t, gettid)
> +#elif defined(__NR_gettid)
> +static inline pid_t gettid(void)
> +{
> +	return syscall(__NR_gettid);
> +}
> +#else
> +#warning "use pid as tid"
> +static inline pid_t gettid(void)
> +{
> +	return getpid();
> +}
> +#endif
> +
>  #include "urcu.h"
>  
>  struct test_array {
> @@ -36,8 +53,8 @@ void *thr_reader(void *arg)
>  	int qparity, i, j;
>  	struct test_array *local_ptr;
>  
> -	printf("thread %s, thread id : %lu, pid %lu\n",
> -			"reader", pthread_self(), (unsigned long)getpid());
> +	printf("thread %s, thread id : %lx, tid %lu\n",
> +			"reader", pthread_self(), (unsigned long)gettid());
>  	sleep(2);
>  
>  	urcu_register_thread();
> @@ -66,8 +83,8 @@ void *thr_writer(void *arg)
>  	int i;
>  	struct test_array *new, *old;
>  
> -	printf("thread %s, thread id : %lu, pid %lu\n",
> -			"writer", pthread_self(), (unsigned long)getpid());
> +	printf("thread %s, thread id : %lx, tid %lu\n",
> +			"writer", pthread_self(), (unsigned long)gettid());
>  	sleep(2);
>  
>  	for (i = 0; i < 10000000; i++) {
> @@ -104,6 +121,9 @@ int main()
>  	void *tret;
>  	int i;
>  
> +	printf("thread %-6s, thread id : %lx, tid %lu\n",
> +			"main", pthread_self(), (unsigned long)gettid());
> +
>  	for (i = 0; i < NR_READ; i++) {
>  		err = pthread_create(&tid_reader[i], NULL, thr_reader, NULL);
>  		if (err != 0)
> -- 
> tg: (24316d1..) bw/use-gettid (depends on: master)
> 

-- 
Mathieu Desnoyers
OpenPGP key fingerprint: 8CD5 52C3 8E3C 4140 715F  BA06 3F25 A8FE 3BAE 9A68
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/