lists.openwall.net   lists  /  announce  owl-users  owl-dev  john-users  john-dev  passwdqc-users  yescrypt  popa3d-users  /  oss-security  kernel-hardening  musl  sabotage  tlsify  passwords  /  crypt-dev  xvendor  /  Bugtraq  Full-Disclosure  linux-kernel  linux-netdev  linux-ext4  linux-hardening  linux-cve-announce  PHC 
Open Source and information security mailing list archives
 
Hash Suite for Android: free password hash cracker in your pocket
[<prev] [next>] [<thread-prev] [day] [month] [year] [list]
Date:	Sun, 8 Feb 2009 10:17:07 -0500 (EST)
From:	Steven Rostedt <rostedt@...dmis.org>
To:	Frederic Weisbecker <fweisbec@...il.com>
cc:	Arnaldo Carvalho de Melo <acme@...hat.com>,
	Ingo Molnar <mingo@...e.hu>,
	Jens Axboe <jens.axboe@...cle.com>,
	Linux Kernel Mailing List <linux-kernel@...r.kernel.org>
Subject: Re: [PATCH tip 2/2] tracing: Introduce
 trace_buffer_{lock_reserve,unlock_commit}


On Sun, 8 Feb 2009, Frederic Weisbecker wrote:
> 
> 
> Ok, yes by making the flags per tracer, it will goes well.
> Just one thing, the insertion of an event is sometimes a hot path
> like with the functions tracer. And such facility adds some unused function calls
> and branch checking.
> But on such cases, we can use directly the ring buffer functions :-)

Yes, please keep the direct calls to the ring buffer on the function 
tracer. The function tracer is also special, in that if we have dynamic 
tracing turned on, we can simply point to a different function that does 
different things depending on trace settings.

Thanks,

-- Steve

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

Powered by blists - more mailing lists