| lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC | |
|
Open Source and information security mailing list archives
| ||
|
Message-ID: <20090209084112.GB32740@shadowen.org> Date: Mon, 9 Feb 2009 08:41:12 +0000 From: Andy Whitcroft <apw@...onical.com> To: Greg KH <greg@...ah.com> Cc: Daniel Walker <dwalker@...o99.com>, linux-kernel@...r.kernel.org Subject: Re: checkpatch.pl is getting too slow On Mon, Feb 02, 2009 at 09:16:32PM -0800, Greg KH wrote: > On Sun, Feb 01, 2009 at 09:47:26AM -0800, Daniel Walker wrote: > > > > > > I found a little more on this.. It seems the problem with #define lines > > only causes a few extra seconds delay .. I found another issue C99 style > > comments. > > > > On line 642 your file has this line, > > > > // For the UART control registers, the application number need to be Or'ed > > > > The quote in Or'ed causes checkpatch to treat the rest of the file as a > > big string that never closes. Or that's my impression. The delay is > > caused in the same way as the define delay. In order to check one line > > in the file the rest of the file is scanned. > > > > The fix below increased the number of errors found too. > > > > total: 347 errors, 278 warnings, 3932 lines checked > > Nice, this looks good to me, thanks for figuring this out. > > Andy, any thoughts? Sorry for the delay, been out of the office this week. Will check these two out. -apw -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@...r.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
Powered by blists - more mailing lists