linux-kernel - Re: [PATCH 1/3] PCI PM: Do not disable and enable bridges during suspend-resume

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20090209093926.GA4358@atrey.karlin.mff.cuni.cz>
Date:	Mon, 9 Feb 2009 10:39:26 +0100
From:	Pavel Machek <pavel@...e.cz>
To:	"Rafael J. Wysocki" <rjw@...k.pl>
Cc:	Jesse Barnes <jbarnes@...tuousgeek.org>,
	Linus Torvalds <torvalds@...ux-foundation.org>,
	Linux PCI <linux-pci@...r.kernel.org>,
	pm list <linux-pm@...ts.linux-foundation.org>,
	LKML <linux-kernel@...r.kernel.org>
Subject: Re: [PATCH 1/3] PCI PM: Do not disable and enable bridges during suspend-resume

> On Sunday 08 February 2009, Pavel Machek wrote:
> > Hi!
> > 
> > > > > their standard config spaces are restored.  Fix this by not attempting
> > > > > to disable bridges during suspend and enable them during resume.
> > > > ...
> > > > > @@ -428,16 +428,18 @@ static int pci_pm_default_resume(struct 
> > > > >  {
> > > > >  	pci_fixup_device(pci_fixup_resume, pci_dev);
> > > > >  
> > > > > -	if (!pci_is_bridge(pci_dev))
> > > > > -		pci_enable_wake(pci_dev, PCI_D0, false);
> > > > > +	if (pci_is_bridge(pci_dev))
> > > > > +		return 0;
> > > > >  
> > > > > +	pci_enable_wake(pci_dev, PCI_D0, false);
> > > > >  	return pci_pm_reenable_device(pci_dev);
> > > > >  }
> > > > 
> > > > Are you sure? This goes from doing reenable_device to not doing it for
> > > > bridges, seemingly contradicting changelog?
> > > 
> > > Can you explain what you mean, please?
> > 
> > It looks to me like the patch does not match the changelog.
> > 
> > Changelog says "enable bridge during resume", but code does return 0
> > if it seems bridge.
> 
> Ah, I see.  The changelog was supposed to mean that the bridges would not
> be disabled during suspend and also would not be enabled during resume
> (which shouldn't be necessary, since they would be automatically enabled
> as a result of restoring their configuration registers).

You can add my acked-by: when you resubmit with fixed
changelog... :-).
									Pavel
-- 
(english) http://www.livejournal.com/~pavelmachek
(cesky, pictures) http://atrey.karlin.mff.cuni.cz/~pavel/picture/horses/blog.html
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/