linux-kernel - Re: [PATCH 1/2] ring_buffer: fix typing mistake

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20090209142030.GA28580@elte.hu>
Date:	Mon, 9 Feb 2009 15:20:30 +0100
From:	Ingo Molnar <mingo@...e.hu>
To:	Steven Rostedt <rostedt@...dmis.org>
Cc:	Lai Jiangshan <laijs@...fujitsu.com>,
	Linux Kernel Mailing List <linux-kernel@...r.kernel.org>
Subject: Re: [PATCH 1/2] ring_buffer: fix typing mistake


* Steven Rostedt <rostedt@...dmis.org> wrote:

> 
> On Mon, 9 Feb 2009, Lai Jiangshan wrote:
> 
> > 
> > Impact: Fix bug
> > 
> > I found several very very curious line.
> > It's so curious that it may be brought by typing mistake.
> > 
> > When (cpu_buffer->reader_page == cpu_buffer->commit_page):
> > 
> > 1) We haven't copied it for bpage is changed:
> >    bpage = cpu_buffer->reader_page->page;
> >    memcpy(bpage->data, cpu_buffer->reader_page->page->data + read ... )
> > 2) We need update cpu_buffer->reader_page->read, but
> >    "cpu_buffer->reader_page += read;" is not right.
> 
> Ouch! That is a bug.
> 
> Ingo, this is an urgent fix. Want me to pull it in and send it off to you?

Please do, yes.

	Ingo
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/