linux-kernel - Re: [PATCH] libata-sff: fix 32-bit PIO regression

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <49905E70.8000209@ru.mvista.com>
Date:	Mon, 09 Feb 2009 19:48:48 +0300
From:	Sergei Shtylyov <sshtylyov@...mvista.com>
To:	Sergei Shtylyov <sshtylyov@...mvista.com>
Cc:	Hugh Dickins <hugh@...itas.com>, jgarzik@...ox.com,
	linux-ide@...r.kernel.org, linux-kernel@...r.kernel.org,
	alan@...rguk.ukuu.org.uk, rjw@...k.pl
Subject: Re: [PATCH] libata-sff: fix 32-bit PIO regression

Hello, I wrote:

>>>> Yes, looks nice, and works for me.  My only criticism would be,
>>>> minor issue unchanged by your patch, that actually "slop" isn't
>>>> unlikely enough to deserve an "unlikely" - slop of 1 or 3 is
>>>> unlikely, but slop of 2 is quite common.

>>> Common on what types of ATAPI commands? I can hardly believe that 
>>> they are
>>> common on the block I/O...

>> When I checked (mounting and listing a CD), about 34% of
>> commands had slop 2.

>    Hm, that probably involved the raw block reads. I don't remember the 
> raw sector length off-hand but it may well be just even, not divisble by 4.

    Oops, I read "listening" instead of "listing". :-/
    But I thought that listing shouldn't involve anything other than block 
reads. OTOH, I'm not familiar enough with ISO9660... What commands are you 
seeing (if you have them dumped)?

>> But you're right, now I try copying
>> a large file, there's no slop involved in that at all.


>> Hugh

MBR, Sergei
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/