linux-kernel - Re: [Linux-fbdev-devel] [PATCH 6/15] sm501fb: check fb_alloc_cmap return value and handle failure properly

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-Id: <20090209175710.5a837ec0.krzysztof.h1@wp.pl>
Date:	Mon, 9 Feb 2009 17:57:10 +0100
From:	Krzysztof Helt <krzysztof.h1@...pl>
To:	Andres Salomon <dilinger@...ued.net>
Cc:	Andrew Morton <akpm@...ux-foundation.org>,
	linux-fbdev-devel@...ts.sourceforge.net,
	linux-kernel@...r.kernel.org, adaplas@...il.com
Subject: Re: [Linux-fbdev-devel] [PATCH 6/15] sm501fb: check fb_alloc_cmap
 return value and handle failure properly

On Sat, 7 Feb 2009 12:14:48 -0500
Andres Salomon <dilinger@...ued.net> wrote:

> 
> Signed-off-by: Andres Salomon <dilinger@...ian.org>
> ---

Acked-by: Krzysztof Helt <krzysztof.h1@...pl>

>  drivers/video/sm501fb.c |    5 ++++-
>  1 files changed, 4 insertions(+), 1 deletions(-)
> 
> diff --git a/drivers/video/sm501fb.c b/drivers/video/sm501fb.c
> index dcd9879..eb5d73a 100644
> --- a/drivers/video/sm501fb.c
> +++ b/drivers/video/sm501fb.c
> @@ -1525,7 +1525,10 @@ static int sm501fb_init_fb(struct fb_info *fb,
>  	}
>  
>  	/* initialise and set the palette */
> -	fb_alloc_cmap(&fb->cmap, NR_PALETTE, 0);
> +	if (fb_alloc_cmap(&fb->cmap, NR_PALETTE, 0)) {
> +		dev_err(info->dev, "failed to allocate cmap memory\n");
> +		return -ENOMEM;
> +	}
>  	fb_set_cmap(&fb->cmap, fb);
>  
>  	ret = (fb->fbops->fb_check_var)(&fb->var, fb);
> -- 
> 1.5.6.5
> 
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/