linux-kernel - Re: [PATCH 01/11] x86: include correct %gs in a.out core dump

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <4990640D.1070701@goop.org>
Date:	Mon, 09 Feb 2009 09:12:45 -0800
From:	Jeremy Fitzhardinge <jeremy@...p.org>
To:	Tejun Heo <tj@...nel.org>
CC:	hpa@...or.com, tglx@...utronix.de, mingo@...e.hu,
	linux-kernel@...r.kernel.org, x86@...nel.org, rusty@...tcorp.com.au
Subject: Re: [PATCH 01/11] x86: include correct %gs in a.out core dump

Tejun Heo wrote:
> Impact: dump the correct %gs into a.out core dump
>
> aout_dump_thread() read %gs but didn't include it in core dump.  Fix
> it.
>
> Signed-off-by: Tejun Heo <tj@...nel.org>
> ---
>  arch/x86/include/asm/a.out-core.h |    4 +---
>  1 files changed, 1 insertions(+), 3 deletions(-)
>
> diff --git a/arch/x86/include/asm/a.out-core.h b/arch/x86/include/asm/a.out-core.h
> index 3782220..3c601f8 100644
> --- a/arch/x86/include/asm/a.out-core.h
> +++ b/arch/x86/include/asm/a.out-core.h
> @@ -23,8 +23,6 @@
>   */
>  static inline void aout_dump_thread(struct pt_regs *regs, struct user *dump)
>  {
> -	u16 gs;
> -
>  /* changed the size calculations - should hopefully work better. lbt */
>  	dump->magic = CMAGIC;
>  	dump->start_code = 0;
> @@ -57,7 +55,7 @@ static inline void aout_dump_thread(struct pt_regs *regs, struct user *dump)
>  	dump->regs.ds = (u16)regs->ds;
>  	dump->regs.es = (u16)regs->es;
>  	dump->regs.fs = (u16)regs->fs;
> -	savesegment(gs, gs);
> +	savesegment(gs, dump->regs.gs);
>   
Yes, that looks like a bit of mindless auto-conversion.

Acked-by: Jeremy Fitzhardinge <jeremy@...p.org>

    J
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/