linux-kernel - Re: [PATCH 08/11] x86: use asm .macro instead of cpp #define in entry

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <4990774E.5080206@goop.org>
Date:	Mon, 09 Feb 2009 10:34:54 -0800
From:	Jeremy Fitzhardinge <jeremy@...p.org>
To:	Tejun Heo <tj@...nel.org>
CC:	hpa@...or.com, tglx@...utronix.de, mingo@...e.hu,
	linux-kernel@...r.kernel.org, x86@...nel.org, rusty@...tcorp.com.au
Subject: Re: [PATCH 08/11] x86: use asm .macro instead of cpp #define in entry_32.S

Tejun Heo wrote:
> Impact: cleanup
>
> Use .macro instead of cpp #define where approriate.  This cleans up
> code and will ease future changes.
>   

I agree with this in principle - cpp macros are indeed very ugly - but 
in practise I've found asm macros to be very hard to work with.  When 
things go wrong, the gas error messages are completely useless (it only 
reports the error on the line where the macro was used, without any 
detail about where in the macro the problem lies), and as far as I know, 
there's no way to see the source with macros expanded.

    J
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/