linux-kernel - Re: [PATCH] drm: count reaches -1, tested 0

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <21d7e9970902081828m709bd839va95b464cd72a4bdb@mail.gmail.com>
Date:	Mon, 9 Feb 2009 12:28:35 +1000
From:	Dave Airlie <airlied@...il.com>
To:	Roel Kluin <roel.kluin@...il.com>
Cc:	airlied@...ux.ie, dri-devel@...ts.sourceforge.net,
	lkml <linux-kernel@...r.kernel.org>,
	Thomas Hellström <thomas@...gstengraphics.com>
Subject: Re: [PATCH] drm: count reaches -1, tested 0

On Mon, Feb 9, 2009 at 12:25 AM, Roel Kluin <roel.kluin@...il.com> wrote:
> With a postfix decrement count will reach -1 rather than 0,
> subsequent tests fail.

Thomas can you sign off on this?

Dave.
>
> Signed-off-by: Roel Kluin <roel.kluin@...il.com>
> ---
> diff --git a/drivers/gpu/drm/via/via_dma.c b/drivers/gpu/drm/via/via_dma.c
> index 7a339db..600315c 100644
> --- a/drivers/gpu/drm/via/via_dma.c
> +++ b/drivers/gpu/drm/via/via_dma.c
> @@ -481,9 +481,9 @@ static int via_wait_idle(drm_via_private_t * dev_priv)
>  {
>        int count = 10000000;
>
> -       while (!(VIA_READ(VIA_REG_STATUS) & VIA_VR_QUEUE_BUSY) && count--);
> +       while (!(VIA_READ(VIA_REG_STATUS) & VIA_VR_QUEUE_BUSY) && --count);
>
> -       while (count-- && (VIA_READ(VIA_REG_STATUS) &
> +       while (--count && (VIA_READ(VIA_REG_STATUS) &
>                           (VIA_CMD_RGTR_BUSY | VIA_2D_ENG_BUSY |
>                            VIA_3D_ENG_BUSY))) ;
>        return count;
> @@ -705,7 +705,7 @@ static int via_cmdbuf_size(struct drm_device *dev, void *data, struct drm_file *
>        switch (d_siz->func) {
>        case VIA_CMDBUF_SPACE:
>                while (((tmp_size = via_cmdbuf_space(dev_priv)) < d_siz->size)
> -                      && count--) {
> +                      && --count) {
>                        if (!d_siz->wait) {
>                                break;
>                        }
> @@ -717,7 +717,7 @@ static int via_cmdbuf_size(struct drm_device *dev, void *data, struct drm_file *
>                break;
>        case VIA_CMDBUF_LAG:
>                while (((tmp_size = via_cmdbuf_lag(dev_priv)) > d_siz->size)
> -                      && count--) {
> +                      && --count) {
>                        if (!d_siz->wait) {
>                                break;
>                        }
>
> --
> To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
> the body of a message to majordomo@...r.kernel.org
> More majordomo info at  http://vger.kernel.org/majordomo-info.html
> Please read the FAQ at  http://www.tux.org/lkml/
>
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/