linux-kernel - Re: [Linux-fbdev-devel] [PATCH 14/15] amifb: check fb_alloc_cmap return value and handle failure properly

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-Id: <20090209212629.611bd99d.krzysztof.h1@wp.pl>
Date:	Mon, 9 Feb 2009 21:26:29 +0100
From:	Krzysztof Helt <krzysztof.h1@...pl>
To:	Andres Salomon <dilinger@...ued.net>
Cc:	Andrew Morton <akpm@...ux-foundation.org>,
	linux-fbdev-devel@...ts.sourceforge.net,
	linux-kernel@...r.kernel.org, adaplas@...il.com
Subject: Re: [Linux-fbdev-devel] [PATCH 14/15] amifb: check fb_alloc_cmap
 return value and handle failure properly

On Sat, 7 Feb 2009 12:18:57 -0500
Andres Salomon <dilinger@...ued.net> wrote:

> 
> Signed-off-by: Andres Salomon <dilinger@...ian.org>
> ---

Acked-by: Krzysztof Helt <krzysztof.h1@...pl>

One comment below.

>  drivers/video/amifb.c |    7 +++++--
>  1 files changed, 5 insertions(+), 2 deletions(-)
> 
> diff --git a/drivers/video/amifb.c b/drivers/video/amifb.c
> index 100f236..82bedd7 100644
> --- a/drivers/video/amifb.c
> +++ b/drivers/video/amifb.c
> @@ -2437,7 +2437,9 @@ default_chipset:
>  		goto amifb_error;
>  	}
>  
> -	fb_alloc_cmap(&fb_info.cmap, 1<<fb_info.var.bits_per_pixel, 0);
> +	err = fb_alloc_cmap(&fb_info.cmap, 1<<fb_info.var.bits_per_pixel, 0);
> +	if (err)
> +		goto amifb_error;
>  
>  	if (register_framebuffer(&fb_info) < 0) {
>  		err = -EINVAL;
> @@ -2456,7 +2458,8 @@ amifb_error:
>  
>  static void amifb_deinit(void)
>  {
> -	fb_dealloc_cmap(&fb_info.cmap);
> +	if (fb_info.cmap.len)
> +		fb_dealloc_cmap(&fb_info.cmap);

Again, is the "if(fb_info.cmap.len)" needed here?

>  	chipfree();
>  	if (videomemory)
>  		iounmap((void*)videomemory);
> -- 
> 1.5.6.5
> 
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/