Message-Id: <200902092232.59353.s.L-H@gmx.de>
Date:	Mon, 9 Feb 2009 22:32:57 +0100
From:	Stefan Lippers-Hollmann <s.L-H@....de>
To:	Greg KH <gregkh@...e.de>
Cc:	linux-kernel@...r.kernel.org
Subject: Re: patch acpi-remove-locking-from-pm1x_sts-register-reads.patch added to 2.6.28-stable tree

Hi

On Montag, 9. Februar 2009, Greg KH wrote:
> On Mon, Feb 09, 2009 at 01:24:43AM +0100, Stefan Lippers-Hollmann wrote:
[...]
> Odd, it builds for me.  I see acpi_get_register_unlocked being defined
> in include/acpi/acpixf.h and then implemented in
> drivers/acpi/hardware/hwregs.c in the 2.6.28.4 + queue tree.
> 
> Do you not have it somehow?

$ grep -R acpi_get_register_unlocked .
./drivers/acpi/hardware/hwsleep.c:              status = acpi_get_register_unlocked(ACPI_BITREG_WAKE_STATUS,
./drivers/acpi/hardware/hwregs.c:acpi_status acpi_get_register_unlocked(u32 register_id, u32 * return_value)
./drivers/acpi/hardware/hwregs.c:       status = acpi_get_register_unlocked(register_id, return_value);
./drivers/acpi/processor_idle.c:                acpi_get_register_unlocked(ACPI_BITREG_BUS_MASTER_STATUS, &bm_status);
./drivers/acpi/processor_idle.c:        acpi_get_register_unlocked(ACPI_BITREG_BUS_MASTER_STATUS, &bm_status);
./include/acpi/acpixf.h:acpi_status acpi_get_register_unlocked(u32 register_id, u32 *return_value);

> Do you think this patch shouldn't be added to the tree?  If so, I have
> no objection to removing it, it just looked like a bugfix that would be
> good to backport.
[...]

Not that it really matters anymore, but my previous paste likely hid the 
real place where the build failure happened due to using parallel make 
(-j8). Attached is the problematic (large) config and a transcript to 
reproduce the build failure without resolving to any distribution 
packaging[1].

$ wget http://eu.kernel.org/pub/linux/kernel/v2.6/linux-2.6.28.tar.bz2
$ wget http://eu.kernel.org/pub/linux/kernel/v2.6/patch-2.6.28.4.bz2
$ tar -xjf linux-2.6.28.tar.bz2
$ cd linux-2.6.28/
$ bzcat ../patch-2.6.28.4.bz2 | patch -p1
$ cp -r <state of stable-queue as of ~16 hours ago>/patches .
$ LANG= quilt push -aq
Applying patch stable/sgi-xp-fix-writing-past-the-end-of-kzalloc-d-space.patch
Applying patch stable/do_wp_page-fix-regression-with-execute-in-place.patch
Applying patch stable/wait-prevent-exclusive-waiter-starvation.patch
Applying patch stable/shm-fix-shmctl-lockup-with-config_shmem.patch
Applying patch stable/revert-rlimit-permit-setting-rlimit_nofile-to-rlim_infinity.patch
Applying patch stable/prevent-kprobes-from-catching-spurious-page-faults.patch
Applying patch stable/sound-usb-audio-handle-wmaxpacketsize-for-fixed_endpoint-devices.patch
Applying patch stable/md-ensure-an-md-array-never-has-too-many-devices.patch
Applying patch stable/md-fix-a-bug-in-linear.c-causing-which_dev-to-return-the-wrong-device.patch
Applying patch stable/acpi-enable-bit-11-in-_pdc-to-advertise-hw-coord.patch
Applying patch stable/acpi-dock-don-t-eval-_sta-on-every-show_docked-sysfs-read.patch
Applying patch stable/ieee1394-ohci1394-increase-at-req.-retries-fix-ack_busy_x-from-panasonic-camcorders-and-others.patch
Applying patch stable/firewire-ohci-increase-at-req.-retries-fix-ack_busy_x-from-panasonic-camcorders-and-others.patch
Applying patch stable/firewire-sbp2-fix-dma-mapping-leak-on-the-failure-path.patch
Applying patch stable/firewire-sbp2-add-workarounds-for-2nd-and-3rd-generation-ipods.patch
Applying patch stable/ieee1394-sbp2-add-workarounds-for-2nd-and-3rd-generation-ipods.patch
Applying patch stable/module-remove-over-zealous-check-in-__module_get.patch
Applying patch stable/serial-rs485-ioctl-structure-uses-__u32-include-linux-types.h.patch
Applying patch stable/x86-apic-enable-workaround-on-amd-fam10h-cpus.patch
Applying patch stable/eeepc-laptop-fix-oops-when-changing-backlight-brightness-during-eeepc-laptop-init.patch
Applying patch stable/eeepc-laptop-add-support-for-extended-hotkeys.patch
Applying patch stable/e1000-fix-bug-with-shared-interrupt-during-reset.patch
Applying patch stable/e1000-fix-pci-enable-to-honor-the-need_ioport-flag.patch
Applying patch stable/agp-intel-add-support-for-g41-chipset.patch
Applying patch stable/agp-intel-fix-broken-symbol-in-device-name.patch
Applying patch stable/alsa-hda-add-quirk-for-fsc-amilo-xi2550.patch
Applying patch stable/alsa-hda-add-missing-coef-initialization-for-alc887.patch
Applying patch stable/alsa-hda-add-missing-initialization-for-alc272.patch
Applying patch stable/asus_acpi-add-r1f-support.patch
Applying patch stable/panasonic-laptop-fix-x.patch
Applying patch stable/acpi-skip-the-first-two-elements-in-the-_bcl-package.patch
Applying patch stable/acpi-remove-locking-from-pm1x_sts-register-reads.patch
Applying patch stable/acpi-proc_dir_entry-video-vga-already-registered.patch
Applying patch stable/acpi-disable-acpi-cleanly-when-bad-rsdp-found.patch
Applying patch stable/acpica-fix-table-entry-truncation-calculation.patch
Applying patch stable/pci-properly-clean-up-aspm-link-state-on-device-remove.patch
Applying patch stable/pci-return-error-on-failure-to-read-pci-roms.patch
Applying patch stable/seq_file-move-traverse-so-it-can-be-used-from-seq_read.patch
Applying patch stable/seq_file-fix-big-enough-lseek-read.patch
Applying patch stable/serial-set-correct-baud_base-for-oxford-semiconductor-ltd-exsys-ex-41092-dual-16950-serial-adapter.patch
Applying patch stable/add-support-for-8-port-rs-232-mic-3620-from-advantech.patch
Applying patch stable/mm-fix-error-case-in-mlock-downgrade-reversion.patch
Now at patch stable/mm-fix-error-case-in-mlock-downgrade-reversion.patch
$ zcat /proc/config.gz > .config
$ make oldconfig
$ make -j6 bzImage
$ make modules
[...]
  CC [M]  drivers/acpi/processor_core.o
  CC [M]  drivers/acpi/processor_throttling.o
  CC [M]  drivers/acpi/processor_idle.o
  CC [M]  drivers/acpi/processor_thermal.o
  CC [M]  drivers/acpi/processor_perflib.o
  LD [M]  drivers/acpi/processor.o
[...]
  LD [M]  lib/zlib_deflate/zlib_deflate.o
  Building modules, stage 2.
  MODPOST 2151 modules
ERROR: "acpi_get_register_unlocked" [drivers/acpi/processor.ko] undefined!
make[1]: *** [__modpost] Error 1
make: *** [modules] Error 2

Involved are gcc-4.3 and amd64.

Regards
	Stefan Lippers-Hollmann

[1]	http://svn.berlios.de/svnroot/repos/fullstory/linux-sidux-2.6/trunk/
	svn://svn.berlios.de/fullstory/linux-sidux-2.6/trunk
	(the debian/ directory gets dropped into the unpackaged kernel 
	 tarball and built using "dpkg-buildpackage -rfakeroot -us -uc"
	 in simplified theory (easier to reproduce on a Debian derived 
	 distribution). In practice it's pbuilder hooked into 
	 svn-buildpackage in "merge mode", but all of this would be Debian 
	 specific and given that this is reproducable with plain -stable
	 + stable-queue and without any distribution specific involvement, 
	 all of this is only of academic value)

View attachment "config-2.6.28-4.slh.3-sidux-amd64" of type "text/plain" (90337 bytes)

Powered by blists - more mailing lists