[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Message-Id: <1234215371.17365.16.camel@think.oraclecorp.com>
Date: Mon, 09 Feb 2009 16:36:11 -0500
From: Chris Mason <chris.mason@...cle.com>
To: Chuck Ebbert <cebbert@...hat.com>,
Kyle McMartin <kyle@...radead.org>, jeffm@...e.de,
Linus Torvalds <torvalds@...ux-foundation.org>
Cc: linux-kernel@...r.kernel.org, Ingo Molnar <mingo@...e.hu>
Subject: Re: Build failure with latest -git: btrfs on ppc64
On Sat, 2009-02-07 at 15:50 -0500, Chuck Ebbert wrote:
> fs/btrfs/locking.c: In function 'btrfs_path_lock_waiting':
> fs/btrfs/locking.c:254: error: implicit declaration of function '__raw_spin_is_contended'
>
> Looks like spin_is_contended() is only available on mips and x86??
Btrfs was using spin_is_contended to decide if it should drop locks
before doing an expensive operation during the core btree search. After
a few latency tests here, I think it makes more sense to always drop
them instead.
Linus, if you pull from:
git://git.kernel.org/pub/scm/linux/kernel/git/mason/btrfs-unstable.git
You'll get the build fix for btrfs on arches without ticket spinlocks
fs/btrfs/ctree.c | 3 +--
fs/btrfs/locking.c | 22 ----------------------
fs/btrfs/locking.h | 2 --
3 files changed, 1 insertion(+), 26 deletions(-)
-chris
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/
Powered by blists - more mailing lists