linux-kernel - [PATCH] libata: change drive ready wait after hard reset to 5s

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <DFEF91B22ED07447AB6AA4B237F913F902185A2B@ausx3mpc125.aus.amer.dell.com>
Date:	Mon, 9 Feb 2009 15:48:45 -0600
From:	<Stuart_Hayes@...l.com>
To:	<jeff@...zik.org>, <linux-scsi@...r.kernel.org>,
	<James.Bottomley@...senPartnership.com>
Cc:	<linux-kernel@...r.kernel.org>, <linux-ide@...r.kernel.org>,
	<Mario_Limonciello@...l.com>
Subject: [PATCH] libata: change drive ready wait after hard reset to 5s

I'm re-sending this patch... I didn't get a response last time I sent
this in a week ago.  (Is there something wrong with it?)  Thanks!  ...
Stuart

This fixes problems during resume with drives that take longer than 1s
to be ready.  The ATA-6 spec appears to allow 5 seconds for a drive to
be ready.

On one affected system, this patch changes "PM: resume devices took..."
message from 17 seconds to 4 seconds, and gets rid of a lot of ugly
timeout/error messages.

Without this patch, the libata code moves on after 1s, tries to send a
soft reset (which the drive doesn't see because it isn't ready) which
also times out, then an IDENTIFY command is sent to the drive which
times out, and finally the error handler will try to send another hard
reset which will finally get things working.

Sorry to send as an attachment, but my mail server will wrap text.

Signed-off-by: Stuart Hayes <stuart_hayes@...l.com>

Download attachment "sata_wait5s_on_resume.patch" of type "application/octet-stream" (384 bytes)