linux-kernel - Re: [PATCH] PCI/MSI: fix msi

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <498FB185.3070201@jp.fujitsu.com>
Date:	Mon, 09 Feb 2009 13:31:01 +0900
From:	Hidetoshi Seto <seto.hidetoshi@...fujitsu.com>
To:	Matthew Wilcox <matthew@....cx>
CC:	linux-pci@...r.kernel.org, linux-kernel@...r.kernel.org,
	Matthew Wilcox <willy@...ux.intel.com>,
	Jesse Barnes <jbarnes@...tuousgeek.org>
Subject: Re: [PATCH] PCI/MSI: fix msi_mask() (rev. 2)

Matthew Wilcox wrote:
> On Mon, Feb 09, 2009 at 10:40:55AM +0900, Hidetoshi Seto wrote:
>> The commit bffac3c593eba1f9da3efd0199e49ea6558a40ce ("PCI MSI: Fix
>> undefined shift by 32") does:
> 
> I think the commit message could be worded somewhat better, and I think
> I should be credited as the author of the patch.  How about this?
> 
> ----
> 
> From: Matthew Wilcox <willy@...ux.intel.com>
> 
> Hidetoshi Seto points out that commit
> bffac3c593eba1f9da3efd0199e49ea6558a40ce has wrong values in the
> array.  Rather than correct the array, we can just use a bounds check
> and perform the calculation specified in the comment.  As a bonus, this
> will not run off the end of the array if the device specifies an illegal
> value in the MSI capcbility.
                   ^^^^^^^^^^ capability

> 
> Signed-off-by: Matthew Wilcox <willy@...ux.intel.com>
> Signed-off-by: Hidetoshi Seto <seto.hidetoshi@...fujitsu.com>

It looks good for me other than the typo above.

Thanks,
H.Seto

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/