lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC | |
Open Source and information security mailing list archives
| ||
|
Date: Tue, 10 Feb 2009 01:44:22 +0100 From: Laurent Pinchart <laurent.pinchart@...net.be> To: Ingo Molnar <mingo@...e.hu> Cc: linux-kernel@...r.kernel.org, Mauro Carvalho Chehab <mchehab@...hat.com>, "Rafael J. Wysocki" <rjw@...k.pl> Subject: Re: [build bug] uvc_status_cleanup(): undefined reference to `input_unregister_device' Hi Ingo, On Sunday 08 February 2009 15:58:35 Ingo Molnar wrote: > Hi, havent seen this reported on lkml yet. > > -tip testing found that certain (user-reachable) Kconfig combinations > can cause this build failure on latest mainline: > > drivers/built-in.o: In function `uvc_status_cleanup': > (.text+0x221cca): undefined reference to `input_unregister_device' > drivers/built-in.o: In function `uvc_status_init': > (.text+0x221d4c): undefined reference to `input_allocate_device' > drivers/built-in.o: In function `uvc_status_init': > (.text+0x221db3): undefined reference to `input_free_device' > drivers/built-in.o: In function `uvc_status_init': > (.text+0x221ec6): undefined reference to `input_register_device' > drivers/built-in.o: In function `uvc_status_complete': > uvc_status.c:(.text+0x2222ec): undefined reference to `input_event' > > triggered on v2.6.29-rc3-697-gae1a25d. The problem is this combination: > > CONFIG_INPUT=m > CONFIG_USB_VIDEO_CLASS=y > CONFIG_USB_VIDEO_CLASS_INPUT_EVDEV=y Thanks for the report. The following patch should fix the issue. diff --git a/drivers/media/video/uvc/Kconfig b/drivers/media/video/uvc/Kconfig index c2d9760..0dbe7b9 100644 --- a/drivers/media/video/uvc/Kconfig +++ b/drivers/media/video/uvc/Kconfig @@ -9,7 +9,7 @@ config USB_VIDEO_CLASS config USB_VIDEO_CLASS_INPUT_EVDEV bool "UVC input events device support" default y - depends on USB_VIDEO_CLASS && INPUT + depends on USB_VIDEO_CLASS && (INPUT = y || INPUT = USB_VIDEO_CLASS) ---help--- This option makes USB Video Class devices register an input device to report button events. I'm not completely satisfied with this though, as the USB_VIDEO_CLASS_INPUT_EVDEV completely disappears from the configuration menu if INPUT is set to 'm' and USB_VIDEO_CLASS to 'y'. Being no Kconfig guru, I'd appreciate if someone could help me to find a nicer fix (if that's possible at all). Laurent Pinchart -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@...r.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
Powered by blists - more mailing lists