linux-kernel - Re: [PATCH] i8327: fix outb() parameter order

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20090210121404.GB19297@elte.hu>
Date:	Tue, 10 Feb 2009 13:14:04 +0100
From:	Ingo Molnar <mingo@...e.hu>
To:	Clemens Ladisch <clemens@...isch.de>
Cc:	Pierre Ossman <drzeus@...eus.cx>,
	lkml <linux-kernel@...r.kernel.org>,
	"H. Peter Anvin" <hpa@...or.com>,
	Thomas Gleixner <tglx@...utronix.de>
Subject: Re: [PATCH] i8327: fix outb() parameter order


* Clemens Ladisch <clemens@...isch.de> wrote:

> In i8237A_resume(), when resetting the DMA controller, the parameters to
> dma_outb() were mixed up.
> 
> Signed-off-by: Clemens Ladisch <clemens@...isch.de>
> 
> --- linux-2.6.orig/arch/x86/kernel/i8237.c
> +++ linux-2.6/arch/x86/kernel/i8237.c
> @@ -28,8 +28,8 @@ static int i8237A_resume(struct sys_devi
>  
>  	flags = claim_dma_lock();
>  
> -	dma_outb(DMA1_RESET_REG, 0);
> -	dma_outb(DMA2_RESET_REG, 0);
> +	dma_outb(0, DMA1_RESET_REG);
> +	dma_outb(0, DMA2_RESET_REG);
>  
>  	for (i = 0;i < 8;i++) {
>  		set_dma_addr(i, 0x000000);

Good catch, applied to tip:x86/urgent, thanks!

	Ingo
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/