linux-kernel - Re: [PATCH 1/2] tracing/sysprof: add missing tracing_{start,stop}_record

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20090210125424.GC12820@ghostprotocols.net>
Date:	Tue, 10 Feb 2009 10:54:24 -0200
From:	Arnaldo Carvalho de Melo <acme@...hat.com>
To:	Frederic Weisbecker <fweisbec@...il.com>
Cc:	Ingo Molnar <mingo@...e.hu>, Steven Rostedt <rostedt@...dmis.org>,
	linux-kernel@...r.kernel.org
Subject: Re: [PATCH 1/2] tracing/sysprof: add missing
	tracing_{start,stop}_record_cmdline()

Em Tue, Feb 10, 2009 at 04:43:30AM +0100, Frederic Weisbecker escreveu:
> Add the missing pair tracing_{start,stop}_record_cmdline() to record well
> the cmdline associated with pid.
> 
> Signed-off-by: Frederic Weisbecker <fweisbec@...il.com>

This is another thing that I think begs for a TRACE_INIT_CMDLINE in
struct trace->flags so that just before calling ->init we call
tracing_start_cmdline_record? no?

Another thing I noticed is that even we having a ->stop most of the time
this semantic action is done thru ->reset :-\

- Arnaldo

>  kernel/trace/trace_sysprof.c |    3 +++
>  1 files changed, 3 insertions(+), 0 deletions(-)
> 
> diff --git a/kernel/trace/trace_sysprof.c b/kernel/trace/trace_sysprof.c
> index 84ca9d8..9902c15 100644
> --- a/kernel/trace/trace_sysprof.c
> +++ b/kernel/trace/trace_sysprof.c
> @@ -238,6 +238,8 @@ static int stack_trace_init(struct trace_array *tr)
>  {
>  	sysprof_trace = tr;
>  
> +	tracing_start_cmdline_record();
> +
>  	mutex_lock(&sample_timer_lock);
>  	start_stack_timers();
>  	tracer_enabled = 1;
> @@ -247,6 +249,7 @@ static int stack_trace_init(struct trace_array *tr)
>  
>  static void stack_trace_reset(struct trace_array *tr)
>  {
> +	tracing_stop_cmdline_record();
>  	stop_stack_trace(tr);
>  }
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/