linux-kernel - Re: [PATCH 08/11] x86: use asm .macro instead of cpp #define in entry

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <4990D5F5.9030409@goop.org>
Date:	Mon, 09 Feb 2009 17:18:45 -0800
From:	Jeremy Fitzhardinge <jeremy@...p.org>
To:	Tejun Heo <tj@...nel.org>
CC:	hpa@...or.com, tglx@...utronix.de, mingo@...e.hu,
	linux-kernel@...r.kernel.org, x86@...nel.org, rusty@...tcorp.com.au
Subject: Re: [PATCH 08/11] x86: use asm .macro instead of cpp #define in entry_32.S

Tejun Heo wrote:
> Hmm... I originally did the conversion because I had some .if trick in
> SAVE_ALL which got removed later.  Even after the removal, it
> generally looked like a good idea as x86_64 asm was primarily using
> .macro too.  I do like being able to see the post-processing output of
> cpp too but for assembler disassembling the output often seem to give
> enough clue,
That's assuming that the file assembles.  But if you're trying to 
assemble and the best error the assembler comes up with is "bad operand" 
on the line where you're using the macro, its extremely frustrating 
trying to work out where the problem actually lies.

    J
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/