linux-kernel - Re: [RFC PATCH 0/2] Add VFS support for looking up paths on remote servers using a temporary mount namespace

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20090210155820.GB29075@fieldses.org>
Date:	Tue, 10 Feb 2009 10:58:20 -0500
From:	"J. Bruce Fields" <bfields@...ldses.org>
To:	Trond Myklebust <Trond.Myklebust@...app.com>
Cc:	linux-fsdevel@...r.kernel.org, linux-nfs@...r.kernel.org,
	linux-kernel@...r.kernel.org, viro@...iv.linux.org.uk
Subject: Re: [RFC PATCH 0/2] Add VFS support for looking up paths on remote
	servers using a temporary mount namespace

On Mon, Feb 09, 2009 at 01:45:34PM -0500, Trond Myklebust wrote:
> The following two patches attempt to improve NFSv4's ability to look up
> the mount path on a remote server.
> 
> The first patch adds VFS support for walking the remote path, using a
> temporary mount namespace to represent the server's namespace, so that
> symlinks

I'm a bit confused about the symlink case--I take it you're assuming
that symlinks in the pseudofs should be interpreted as relative to the
server's namespace (in keeping with traditional implementations of
server exports), while symlinks elsewhere should continue to be
intepreted relative to the client's namespace.

Do the rfc's say anything about this?

--b.

> and referrals can be followed across remote filesystem and
> server boundaries.
> The second patch then uses this VFS helper in the NFSv4 mount code.
> 
> A later set of patches will clean out the legacy nfs4_path_walk, however
> I'm hoping for some commentary from the VFS folks on whether or not this
> approach is acceptable before I continue.
> 
> Cheers
>   Trond
> 
> ---
> 
> Trond Myklebust (2):
>       NFSv4: Use vfs_path_lookup() instead of nfs4_path_walk()
>       VFS: Add a VFS helper function vfs_remote_path_lookup()
> 
> 
>  fs/namei.c                    |   75 ++++++++++++++++++++-
>  fs/namespace.c                |   56 +++++++++++++--
>  fs/nfs/super.c                |  149 +++++++++++++++++++++++++++++++++++------
>  include/linux/mnt_namespace.h |    2 +
>  include/linux/namei.h         |    2 +
>  include/linux/nsproxy.h       |    1 
>  kernel/nsproxy.c              |   11 +++
>  7 files changed, 267 insertions(+), 29 deletions(-)
> 
> -- 
> Signature
> --
> To unsubscribe from this list: send the line "unsubscribe linux-nfs" in
> the body of a message to majordomo@...r.kernel.org
> More majordomo info at  http://vger.kernel.org/majordomo-info.html
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/