linux-kernel - Re: [Regression] hald segfaults at startup on Toshiba Portege R500 x86

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-Id: <200902101728.49653.mkossmann_ml1@gmx.de>
Date:	Tue, 10 Feb 2009 17:28:49 +0100
From:	Markus Koßmann <mkossmann_ml1@....de>
To:	Pierre Ossman <drzeus@...eus.cx>
Cc:	"Rafael J. Wysocki" <rjw@...k.pl>,
	Andrew Morton <akpm@...ux-foundation.org>,
	LKML <linux-kernel@...r.kernel.org>,
	" Éric Piel" <eric.piel@...mplin-utc.net>
Subject: Re: [Regression] hald segfaults at startup on Toshiba Portege R500 x86_64 (bisected)

Am Donnerstag, 8. Januar 2009 schrieb Pierre Ossman:
> On Thu, 8 Jan 2009 08:27:02 +0100
>
> "Rafael J. Wysocki" <rjw@...k.pl> wrote:
> > Hi,
> >
> > Unfortunately the following commit:
> >
> > commit 35ff8554d12ecc80a46ea0d9bce34fe28733ff38
> > Author: Éric Piel <eric.piel@...mplin-utc.net>
> > Date:   Sat Nov 22 19:29:29 2008 +0100
> >
> >     sdhci: activate led support also when module
> >
> >     CONFIG_LEDS_CLASS is defined only if led-class is built-in, otherwise
> >     when it is a module the option is called CONFIG_LEDS_CLASS_MODULE.
> > Led support should also be activated in this case.
> >
> >     Signed-off-by: Eric Piel <eric.piel@...mplin-utc.net>
> >     Signed-off-by: Pierre Ossman <drzeus@...eus.cx>
> >
> > causes hald to segfault at startup (not always, but sufficiently often
> > for bisection) on my Toshiba Portege R500 w/ x86_64 kernel/userland.
>
> I have trouble seeing a user space application crashing as a kernel
> bug. Do you have a backtrace or strace of hald to see exactly where it
> crashes?
>
> > While it doesn't revert cleanly, I have applied the appended patch (which
> > is a revert of the commit above) and hald doesn't segfault any more here.
>
> Is CONFIG_LEDS_CLASS defined in your config, or are you essentially
> turning of the LED functionality?
>
> Rgds

Hi Pierre; 
it seems that I see the same problem here on my HP8530w laptop ( 64bit 
kernel/userland and sdhci compiled as module). When starting up the system 
with SUSEs KOTD 2.6.29-rc4-master_20090209165007_20c19cf8-default 
hald crashes with something like: 
Feb 10 15:23:02 linux-gpi4 kernel: hald[5216]: segfault at 20 ip 000000000042f
4ab sp 00007ffff343b5e0 error 4 in hald[400000+55000]:

After applying Rafaels patch the problem goes away. 

I attach straces of hald from both unpatched and patched kernel. 




View attachment "hald_trace.patched" of type "text/plain" (8851 bytes)

View attachment "hald_trace.unpatched" of type "text/plain" (10783 bytes)