linux-kernel - Re: [PATCH] softlockup: ensure the task has been switched out once

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20090210181504.GI7332@google.com>
Date:	Tue, 10 Feb 2009 10:15:04 -0800
From:	Mandeep Singh Baines <msb@...gle.com>
To:	Frederic Weisbecker <fweisbec@...il.com>
Cc:	Ingo Molnar <mingo@...e.hu>, linux-kernel@...r.kernel.org,
	rientjes@...gle.com, mbligh@...gle.com, thockin@...gle.com
Subject: Re: [PATCH] softlockup: ensure the task has been switched out once

Frederic Weisbecker (fweisbec@...il.com) wrote:
> When we check if a task has been switched out since the last scan, we might
> have a race condition on the following scenario:
> 
> _ the task is freshly created and scheduled
> _ it puts its state to TASK_UNINTERRUPTIBLE and is not yet switched out
> _ check_hung_task() scans this task and will report a false positive because
>   t->nvcsw + t->nivcsw == t->last_switch_count == 0
> 
> Add a check for such cases.
> 
> Signed-off-by: Frederic Weisbecker <fweisbec@...il.com>
> ---
>  kernel/hung_task.c |    8 +++++++-
>  1 files changed, 7 insertions(+), 1 deletions(-)
> 
> diff --git a/kernel/hung_task.c b/kernel/hung_task.c
> index 0c924de..022a492 100644
> --- a/kernel/hung_task.c
> +++ b/kernel/hung_task.c
> @@ -72,7 +72,13 @@ static void check_hung_task(struct task_struct *t, unsigned long timeout)
>  {
>  	unsigned long switch_count = t->nvcsw + t->nivcsw;
>  
> -	if (t->flags & PF_FROZEN)
> +	/*
> +	 * Ensure the task is not frozen.
> +	 * Also, when a freshly created task is scheduled once, changes
> +	 * its state to TASK_UNINTERRUPTIBLE without having ever been
> +	 * switched out once, it musn't be checked.
> +	 */
> +	if (unlikely(t->flags & PF_FROZEN || !switch_count))
>  		return;
>  
>  	if (switch_count != t->last_switch_count) {
> -- 
> 1.6.1
> 
> 


Looks good to me. Thanks for fixing this!

Acked-by: Mandeep Singh Baines <msb@...gle.com>
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/