linux-kernel - Re: [PATCH 3/4] Move FASYNC bit handling to f

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20090209194156.1f6a60b0@bike.lwn.net>
Date:	Mon, 9 Feb 2009 19:41:56 -0700
From:	Jonathan Corbet <corbet@....net>
To:	Christoph Hellwig <hch@....de>
Cc:	linux-kernel@...r.kernel.org, Andi Kleen <andi@...stfloor.org>,
	Oleg Nesterov <oleg@...hat.com>,
	Andrew Morton <akpm@...ux-foundation.org>,
	Al Viro <viro@...IV.linux.org.uk>,
	Davide Libenzi <davidel@...ilserver.org>,
	David Miller <davem@...emloft.net>,
	Christoph Hellwig <hch@....de>,
	Alan Cox <alan@...rguk.ukuu.org.uk>,
	Matt Mackall <mpm@...enic.com>
Subject: Re: [PATCH 3/4] Move FASYNC bit handling to f_op->fasync()

On Sun, 8 Feb 2009 10:05:50 +0100
Christoph Hellwig <hch@....de> wrote:

> > +	/* Maintaining the FASYNC bit is our job now */  
> 
> Not sure this comment is a good idea.  All comments of the style
> something has changes and is this now get stale really soon.  If you
> want to document that change in more details it should probably go
> into Documentation/filesystems/Locking near the fasync part.

Good point.  I've removed the comment and updated the doc file instead.

Thanks,

jon
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/