linux-kernel - Re: [PATCH 1/1] NBD: fix I/O hang on disconnected nbds

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <4991F75D.7010100@steeleye.com>
Date:	Tue, 10 Feb 2009 16:53:33 -0500
From:	Paul Clements <paul.clements@...eleye.com>
To:	Andrew Morton <akpm@...ux-foundation.org>
CC:	linux-kernel@...r.kernel.org, jnelson-kernel-bugzilla@...poni.net,
	Pavel Machek <pavel@....cz>, stable@...nel.org
Subject: Re: [PATCH 1/1] NBD: fix I/O hang on disconnected nbds

Andrew Morton wrote:
> On Mon, 09 Feb 2009 13:21:51 -0500
> Paul Clements <paul.clements@...eleye.com> wrote:

>> This problem was introduced by the new request handling thread code
>> ("NBD: allow nbd to be used locally", 3/2008), which entered into 
>> mainline around 2.6.25.
> 
> Seems that the patch applies to 2.6.26, but not to 2.6.25.

OK, couldn't remember the exact timeframe.

>> The fix, which is fairly simple, is to restore the check for lo->sock
>> being NULL in do_nbd_request. This causes I/O to an uninitialized nbd to
>> immediately fail with an I/O error, as it did prior to the introduction 
>> of this bug.
> 
> I marked this as needing backporting into 2.6.26.x, 2.6.27.x and
> 2.6.28.x.  OK?

Yes, that would be a good idea.

Thanks,
Paul


--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/