linux-kernel - Re: [PATCH][BUILDERR] mm: Fix build error with !CONFIG

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-Id: <B5B23369-BEA0-4420-9967-28ABC53B3C4B@kernel.crashing.org>
Date:	Tue, 10 Feb 2009 16:57:36 -0600
From:	Kumar Gala <galak@...nel.crashing.org>
To:	Frans Pop <elendil@...net.nl>
Cc:	Linux Kernel Mailing List <linux-kernel@...r.kernel.org>,
	Mel Gorman <mel@....ul.ie>,
	Linus Torvalds <torvalds@...ux-foundation.org>
Subject: Re: [PATCH][BUILDERR] mm: Fix build error with !CONFIG_HUGETLBFS


On Feb 10, 2009, at 4:51 PM, Frans Pop wrote:

> In commit 5a6fe1259506 an extra parameter was added to  
> hugetlb_file_setup(),
> but the header file was not updated for the !CONFIG_HUGETLBFS case,  
> which
> results in:
>
> ipc/shm.c:371:49: error: macro "hugetlb_file_setup" passed 3  
> arguments,
>    but takes just 2
>
> Signed-off-by: Frans Pop <elendil@...net.nl>
> Cc: Mel Gorman <mel@....ul.ie>
>
> diff --git a/include/linux/hugetlb.h b/include/linux/hugetlb.h
> index af09660..03de70f 100644
> --- a/include/linux/hugetlb.h
> +++ b/include/linux/hugetlb.h
> @@ -159,9 +159,9 @@ static inline void set_file_hugepages(struct  
> file *file)
> }
> #else /* !CONFIG_HUGETLBFS */
>
> -#define is_file_hugepages(file)		0
> -#define set_file_hugepages(file)	BUG()
> -#define hugetlb_file_setup(name,size)	ERR_PTR(-ENOSYS)
> +#define is_file_hugepages(file)			0
> +#define set_file_hugepages(file)		BUG()
> +#define hugetlb_file_setup(name,size,int)	ERR_PTR(-ENOSYS)

might be slightly better as:

#define hugetlb_file_setup(name,size,acctflag)	ERR_PTR(-ENOSYS)

otherwise ack.

- k
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/