| lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC | |
|
Open Source and information security mailing list archives
| ||
|
Message-ID: <4992DD86.1030607@s5r6.in-berlin.de> Date: Wed, 11 Feb 2009 15:15:34 +0100 From: Stefan Richter <stefanr@...6.in-berlin.de> To: Hannes Hering <hannes.hering@...ux.vnet.ibm.com> CC: jeff@...zik.org, linux-kernel@...r.kernel.org, linuxppc-dev@...abs.org, netdev@...r.kernel.org, ossrosch@...ux.vnet.ibm.com, ossthema@...ibm.com, raisch@...ibm.com, themann@...ibm.com, osstklei@...ibm.com Subject: Re: [PATCH] ehea: Fix: Remove adapter from adapter list in error path Hannes Hering wrote: > Remove adapter from adapter list before freeing data structure in error path. ... > --- linux-2.6.29-rc4/drivers/net/ehea/ehea_main.c 2009-02-11 13:13:47.812542928 +0100 > +++ patched_kernel/drivers/net/ehea/ehea_main.c 2009-02-11 13:14:04.197540184 +0100 > @@ -3448,6 +3448,7 @@ out_kill_eq: > ehea_destroy_eq(adapter->neq); > > out_free_ad: > + list_del(&adapter->list); > kfree(adapter); > > out: On a related note, ehea_set_mac_addr()/ehea_update_bcmc_registrations() accesses adapter_list without serialization by ehea_fw_handles.lock and thus apparently unsafely. There may be other unsafe accesses of adapter_list; that's just the first one which I spotted. -- Stefan Richter -=====-==--= --=- -=-== http://arcgraph.de/sr/ -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@...r.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
Powered by blists - more mailing lists