linux-kernel - Re: ACPI: S4 disappeared [mmotm 2009-02-10-16-35]

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-Id: <200902111643.10191.rjw@sisk.pl>
Date:	Wed, 11 Feb 2009 16:43:09 +0100
From:	"Rafael J. Wysocki" <rjw@...k.pl>
To:	Jiri Slaby <jirislaby@...il.com>
Cc:	linux-kernel@...r.kernel.org, mm-commits@...r.kernel.org,
	Len Brown <lenb@...nel.org>, linux-acpi@...r.kernel.org,
	"Linux-pm mailing list" <linux-pm@...ts.linux-foundation.org>,
	Pavel Machek <pavel@...e.cz>, Ingo Molnar <mingo@...e.hu>
Subject: Re: ACPI: S4 disappeared [mmotm 2009-02-10-16-35]

On Wednesday 11 February 2009, Jiri Slaby wrote:
> On 02/11/2009 09:51 AM, Jiri Slaby wrote:
> > On 02/11/2009 01:36 AM, akpm@...ux-foundation.org wrote:
> >> The mm-of-the-moment snapshot 2009-02-10-16-35 has been uploaded
> > 
> > Hi,
> > 
> > I've found out, that S4 disappeared in this release, in comparison to mmotm
> > based on 2.6.29-rc2:
> > -ACPI: (supports S0 S1 S3 S4 S5)
> > +ACPI: (supports S0 S1 S3 S5)
> > 
> > Any ideas what could have caused this?
> 
> I think this one
> ARCH_HIBERNATION_POSSIBLE=n
> because
> SMP=y
> since
>  config ARCH_HIBERNATION_POSSIBLE
>         def_bool y
> -       depends on !SMP || !X86_VOYAGER
> +       depends on !SMP
> 
> The condition was wrong, ok, anyway it worked. Would
> depends on !SMP || EXPERIMENTAL
> make sense? The smp is handled in disable_nonboot_cpus manner, right?

Ah, someone removed X86_VOYAGER and left this gem.  I guess that went in
through -tip (Ingo CCed).

After removing X86_VOYAGER, ARCH_HIBERNATION_POSSIBLE should always be set
on x86.  Just make it

config ARCH_HIBERNATION_POSSIBLE
         def_bool y

Thanks,
Rafael
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/