linux-kernel - Re: [PATCH -v3] futex: fix reference leak

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20090211162618.GC32301@elte.hu>
Date:	Wed, 11 Feb 2009 17:26:18 +0100
From:	Ingo Molnar <mingo@...e.hu>
To:	Peter Zijlstra <peterz@...radead.org>
Cc:	"Pallipadi, Venkatesh" <venkatesh.pallipadi@...el.com>,
	Catalin Marinas <catalin.marinas@....com>,
	linux-kernel <linux-kernel@...r.kernel.org>,
	Andrew Morton <akpm@...ux-foundation.org>,
	Darren Hart <dvhltc@...ibm.com>,
	Thomas Gleixner <tglx@...utronix.de>
Subject: Re: [PATCH -v3] futex: fix reference leak


* Peter Zijlstra <peterz@...radead.org> wrote:

> On Wed, 2009-02-11 at 16:49 +0100, Ingo Molnar wrote:
> > * Peter Zijlstra <peterz@...radead.org> wrote:
> > 
> > > So you prefer this version?
> > 
> > yes, with s/out_unlock_put_key/err_unlock_put_key. That's the
> > only error path that goes via the tail of the function, correct?
> 
> Right, but I think one can argue that most of the out* jumps are errors.
> 
> The only non-error return is the !unqueue_me() case.
> 
> Also, since there's only one user of out_unlock_put_key, we might also
> do this:

yeah. Also mark it via unlikely().

	Ingo
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/