linux-kernel - Re: [GIT PULL] x86: more header untangling

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <49931F04.80605@goop.org>
Date:	Wed, 11 Feb 2009 10:55:00 -0800
From:	Jeremy Fitzhardinge <jeremy@...p.org>
To:	Ingo Molnar <mingo@...e.hu>
CC:	the arch/x86 maintainers <x86@...nel.org>,
	Linux Kernel Mailing List <linux-kernel@...r.kernel.org>
Subject: Re: [GIT PULL] x86: more header untangling

Ingo Molnar wrote:
> constants can be considered data types too.

Huh, that's a pretty broad definition of "type", to the degree that's 
its fairly counter-intuitive and misleading.  But I don't care that much.

>  Small inlines are borderlines,
> they should generally not be in _types.h headers. Really, _types.h headers
> are only there to instantiate a type, to enable dependent inline methods
> to use them.
>   

In this case the inlines are the accessor functions to do the pte_t <-> 
pteval_t (un)wrapping.  They're trivial and have no dependencies apart 
from the types they're right next to.

Anyway, check out 
git://git.kernel.org/pub/scm/linux/kernel/git/jeremy/xen.git 
x86/untangle now.  I had to merge in tip/x86/paravirt to get the 
pte_flags changes I made there, and unfortunately it didn't merge 
completely cleanly, so there's probably some spurious changes in there.  
I guess I can respin it into a clean branch.

    J
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/