linux-kernel - Re: [PATCH 2/3] x86: Pass in pt_regs pointer for syscalls that need it

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <73c1f2160902111157g202dbdd2h1bc75b0a8cb242b3@mail.gmail.com>
Date:	Wed, 11 Feb 2009 14:57:57 -0500
From:	Brian Gerst <brgerst@...il.com>
To:	"H. Peter Anvin" <hpa@...or.com>
Cc:	"H. Peter Anvin" <hpa@...nel.org>, Tejun Heo <tj@...nel.org>,
	Ingo Molnar <mingo@...e.hu>, linux-kernel@...r.kernel.org
Subject: Re: [PATCH 2/3] x86: Pass in pt_regs pointer for syscalls that need 
	it

On Wed, Feb 11, 2009 at 2:50 PM, H. Peter Anvin <hpa@...or.com> wrote:
> Brian Gerst wrote:
>>
>> I guess I could go back to extracting the args from the pt_regs struct
>> given just the pointer.  How do you intend to handle system calls in
>> your changes (normal ones, not needing pt_regs)?
>>
>
> My plan was to by default load up the three first arguments in (%eax, %edx,
> %ecx) followed by the remaining arguments on the stack... I currently have
> it as a reorganized struct pt_regs, but I'm still trying to figure out if it
> would make more sense from a correctness and performance perspective to
> instead have duplicates of these entries.
>
> For the pt_regs-using registers, they would need a tiny trampoline, looking
> like:
>
>        leal 16(%esp),%eax
>        jmp <real function>
>
>        -hpa
>
>

IMHO, copying the 4th-6th args to a new stack frame is the only way to
guarantee that gcc won't trash any part of pt_regs.  The question is
whether to do it unconditionally, or try to be clever and only copy
them for the syscalls that actually need them.

--
Brian Gerst
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/