linux-kernel - RE: [PATCH]iwlan dma mapping read and write changes

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-Id: <1234388027.16004.50.camel@johannes.local>
Date:	Wed, 11 Feb 2009 22:33:47 +0100
From:	Johannes Berg <johannes@...solutions.net>
To:	"Winkler, Tomas" <tomas.winkler@...el.com>
Cc:	"Yu, Fenghua" <fenghua.yu@...el.com>,
	David Woodhouse <dwmw2@...radead.org>,
	Ingo Molnar <mingo@...e.hu>,
	Stephen Rothwell <sfr@...b.auug.org.au>,
	Andrew Morton <akpm@...ux-foundation.sc.intel.com>,
	"Grumbach, Emmanuel" <emmanuel.grumbach@...el.com>,
	"Zhu, Yi" <yi.zhu@...el.com>, Chris Wright <chrisw@...s-sol.org>,
	LKML <linux-kernel@...r.kernel.org>,
	"iommu@...ts.linux-foundation.org" <iommu@...ts.linux-foundation.org>
Subject: RE: [PATCH]iwlan dma mapping read and write changes

On Wed, 2009-02-11 at 23:27 +0200, Winkler, Tomas wrote:

> >mapping with PCI_DMA_TODEVICE which is read only in mapping PTE. But iwlan
> >device
> >actually writes to the mapped page to update its contents. This issue is
> >not
> >exposed in swiotlb. But VT-d hardware can capture this fault and stop the
> >fault
> >transaction.
> >
> >The following patch fixes the issue.
> >
> >Signed-off-by: Fenghua Yu <fenghua.yu@...el.com>
> Acked-by: Tomas Winkler <tomas.winkler@...el.com>
> 
> Indeed the firmware/ucode write back to host memory to update retry
> counter for APMDU packets. I'm not sure if this is needed for legacy
> traffic, though.   

I don't think they can be seeing AMPDU packets since that is, well,
broken?

johannes

Download attachment "signature.asc" of type "application/pgp-signature" (837 bytes)