linux-kernel - Re: [PATCHv7] lis3lv02d: support both one- and two-byte sensors

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-Id: <20090211143844.27ca0d6c.akpm@linux-foundation.org>
Date:	Wed, 11 Feb 2009 14:38:44 -0800
From:	Andrew Morton <akpm@...ux-foundation.org>
To:	Giuseppe Bilotta <giuseppe.bilotta@...il.com>
Cc:	linux-kernel@...r.kernel.org, eric.piel@...mplin-utc.net,
	pavel@...e.cz, giuseppe.bilotta@...il.com
Subject: Re: [PATCHv7] lis3lv02d: support both one- and two-byte sensors

On Wed, 11 Feb 2009 11:06:43 +0100
Giuseppe Bilotta <giuseppe.bilotta@...il.com> wrote:

> Sensors responding with 0x3B to WHO_AM_I only have one data register per
> direction, thus returning a signed byte from the position which is
> occupied by the MSB in sensors responding with 0x3A.
> 
> Since multiple sensors share the reply to WHO_AM_I, we rename the
> defines to better indicate what they identify (family of single and
> double precision sensors).
> 
> We support both kind of sensors by checking for the sensor type on init
> and defining appropriate data-access routines and sensor limits (for the
> joystick) depending on what we find.
> 

Which tree is this patch against?

> --- a/drivers/hwmon/lis3lv02d.c
> +++ b/drivers/hwmon/lis3lv02d.c
> @@ -53,9 +53,6 @@
>   * joystick.
>   */
>  
> -/* Maximum value our axis may get for the input device (signed 12 bits) */
> -#define MDPS_MAX_VAL 2048
> -
>  struct acpi_lis3lv02d adev = {
>  	.misc_wait   = __WAIT_QUEUE_HEAD_INITIALIZER(adev.misc_wait),
>  };

Current Linus mainline has

struct acpi_lis3lv02d adev;
EXPORT_SYMBOL_GPL(adev);

here.

Also, this comment:

/*
 * The sensor can also generate interrupts (DRDY) but it's pretty pointless
 * because their are generated even if the data do not change. So it's better
 * to keep the interrupt for the free-fall event. The values are updated at
 * 40Hz (at the lowest frequency), but as it can be pretty time consuming on
 * some low processor, we poll the sensor only at 20Hz... enough for the
 * joystick.
 */

seems to be describing something which isn't there.

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/